10902_opening_hours #152

Open
Anja Leichsenring wants to merge 6 commits from 10902_opening_hours into main
No description provided.
[BUGFIX] Limit search filters to reachable results
All checks were successful
CI / base-qa (pull_request) Successful in 23s
CI / advanced-qa (82, ^13.4) (pull_request) Successful in 2m21s
CI / advanced-qa (82, ^14) (pull_request) Successful in 2m30s
CI / advanced-qa (83, ^13.4) (pull_request) Successful in 2m24s
CI / advanced-qa (83, ^14) (pull_request) Successful in 2m30s
CI / advanced-qa (84, ^13.4) (pull_request) Successful in 2m18s
CI / advanced-qa (84, ^14) (pull_request) Successful in 2m22s
CI / advanced-qa (85, ^13.4) (pull_request) Successful in 2m19s
CI / advanced-qa (85, ^14) (pull_request) Successful in 2m20s
184ad38b15
[FEATURE] Import openingHours as IRRE and compute desired output
Some checks failed
CI / base-qa (pull_request) Failing after 22s
CI / advanced-qa (82, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (82, ^14) (pull_request) Has been skipped
CI / advanced-qa (83, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (83, ^14) (pull_request) Has been skipped
CI / advanced-qa (84, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (84, ^14) (pull_request) Has been skipped
CI / advanced-qa (85, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (85, ^14) (pull_request) Has been skipped
9572c9ad1e
Anja Leichsenring force-pushed 10902_opening_hours from 9572c9ad1e
Some checks failed
CI / base-qa (pull_request) Failing after 22s
CI / advanced-qa (82, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (82, ^14) (pull_request) Has been skipped
CI / advanced-qa (83, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (83, ^14) (pull_request) Has been skipped
CI / advanced-qa (84, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (84, ^14) (pull_request) Has been skipped
CI / advanced-qa (85, ^13.4) (pull_request) Has been skipped
CI / advanced-qa (85, ^14) (pull_request) Has been skipped
to e05d18eaf6
All checks were successful
CI / base-qa (pull_request) Successful in 23s
CI / advanced-qa (82, ^13.4) (pull_request) Successful in 2m16s
CI / advanced-qa (82, ^14) (pull_request) Successful in 2m35s
CI / advanced-qa (83, ^13.4) (pull_request) Successful in 2m21s
CI / advanced-qa (83, ^14) (pull_request) Successful in 2m31s
CI / advanced-qa (84, ^13.4) (pull_request) Successful in 2m17s
CI / advanced-qa (84, ^14) (pull_request) Successful in 2m21s
CI / advanced-qa (85, ^13.4) (pull_request) Successful in 2m19s
CI / advanced-qa (85, ^14) (pull_request) Successful in 2m20s
2026-06-17 13:23:01 +00:00
Compare
[TASK] Provide partial for formatted openinghours output
All checks were successful
CI / base-qa (pull_request) Successful in 26s
CI / advanced-qa (82, ^13.4) (pull_request) Successful in 2m26s
CI / advanced-qa (82, ^14) (pull_request) Successful in 2m38s
CI / advanced-qa (83, ^13.4) (pull_request) Successful in 2m17s
CI / advanced-qa (83, ^14) (pull_request) Successful in 2m30s
CI / advanced-qa (84, ^13.4) (pull_request) Successful in 2m23s
CI / advanced-qa (84, ^14) (pull_request) Successful in 2m27s
CI / advanced-qa (85, ^13.4) (pull_request) Successful in 2m16s
CI / advanced-qa (85, ^14) (pull_request) Successful in 2m18s
5aa4a0e8a4
[TASK] Deprecate opening hours json-blob based handling
All checks were successful
CI / base-qa (pull_request) Successful in 22s
CI / advanced-qa (82, ^13.4) (pull_request) Successful in 2m19s
CI / advanced-qa (82, ^14) (pull_request) Successful in 2m30s
CI / advanced-qa (83, ^13.4) (pull_request) Successful in 2m13s
CI / advanced-qa (83, ^14) (pull_request) Successful in 2m35s
CI / advanced-qa (84, ^13.4) (pull_request) Successful in 2m17s
CI / advanced-qa (84, ^14) (pull_request) Successful in 2m20s
CI / advanced-qa (85, ^13.4) (pull_request) Successful in 2m16s
CI / advanced-qa (85, ^14) (pull_request) Successful in 2m19s
b17758e494
We use inline records now, so the old handling is marked as
deprecated. Imports will create inline records and don't fill
the old json field anymore.
[TASK] Documentation Update
All checks were successful
CI / base-qa (pull_request) Successful in 18s
CI / advanced-qa (82, ^13.4) (pull_request) Successful in 2m24s
CI / advanced-qa (82, ^14) (pull_request) Successful in 2m37s
CI / advanced-qa (83, ^13.4) (pull_request) Successful in 2m17s
CI / advanced-qa (83, ^14) (pull_request) Successful in 2m33s
CI / advanced-qa (84, ^13.4) (pull_request) Successful in 2m17s
CI / advanced-qa (84, ^14) (pull_request) Successful in 2m21s
CI / advanced-qa (85, ^13.4) (pull_request) Successful in 2m22s
CI / advanced-qa (85, ^14) (pull_request) Successful in 2m24s
cdbac0a46b
[TASK] Improve comments
Some checks failed
CI / base-qa (pull_request) Successful in 19s
CI / advanced-qa (82, ^13.4) (pull_request) Failing after 2m18s
CI / advanced-qa (82, ^14) (pull_request) Failing after 2m37s
CI / advanced-qa (83, ^13.4) (pull_request) Failing after 2m19s
CI / advanced-qa (83, ^14) (pull_request) Failing after 2m28s
CI / advanced-qa (84, ^13.4) (pull_request) Failing after 2m23s
CI / advanced-qa (84, ^14) (pull_request) Failing after 2m26s
CI / advanced-qa (85, ^13.4) (pull_request) Failing after 2m22s
CI / advanced-qa (85, ^14) (pull_request) Failing after 2m22s
72df5773aa
Anja Leichsenring changed title from WIP: 10902_opening_hours to 10902_opening_hours 2026-06-23 06:48:55 +00:00
Anja Leichsenring force-pushed 10902_opening_hours from 72df5773aa
Some checks failed
CI / base-qa (pull_request) Successful in 19s
CI / advanced-qa (82, ^13.4) (pull_request) Failing after 2m18s
CI / advanced-qa (82, ^14) (pull_request) Failing after 2m37s
CI / advanced-qa (83, ^13.4) (pull_request) Failing after 2m19s
CI / advanced-qa (83, ^14) (pull_request) Failing after 2m28s
CI / advanced-qa (84, ^13.4) (pull_request) Failing after 2m23s
CI / advanced-qa (84, ^14) (pull_request) Failing after 2m26s
CI / advanced-qa (85, ^13.4) (pull_request) Failing after 2m22s
CI / advanced-qa (85, ^14) (pull_request) Failing after 2m22s
to 60578d927f
All checks were successful
CI / base-qa (pull_request) Successful in 17s
CI / advanced-qa (82, ^13.4) (pull_request) Successful in 2m28s
CI / advanced-qa (82, ^14) (pull_request) Successful in 2m35s
CI / advanced-qa (83, ^13.4) (pull_request) Successful in 2m22s
CI / advanced-qa (83, ^14) (pull_request) Successful in 2m26s
CI / advanced-qa (84, ^13.4) (pull_request) Successful in 2m17s
CI / advanced-qa (84, ^14) (pull_request) Successful in 2m29s
CI / advanced-qa (85, ^13.4) (pull_request) Successful in 2m17s
CI / advanced-qa (85, ^14) (pull_request) Successful in 2m25s
2026-06-23 07:43:49 +00:00
Compare
@ -0,0 +24,4 @@
================== ==========================================================
``mainImage`` The primary image (``main_image``), a single file reference.
``mediaFiles`` Additional images and files (``media_files``).
``editorialImages`` Editorially curated images (``editorial_images``), maintained in the backend.

Rendering is broken here for some reason:
image

Rendering is broken here for some reason: ![image](/attachments/a6c736ee-c193-461c-b94c-41060b3c5c18)
@ -0,0 +20,4 @@
A tourist attraction exposes two computed accessors:
* ``computedOpeningHours`` -- the regular hours.

I love definition lists for this kind of things: https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/Reference/ReStructuredText/Lists/DefinitionLists.html#definition-lists
Something markdown doesn't offer.

But we don't need to switch to them here.

I love definition lists for this kind of things: https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/Reference/ReStructuredText/Lists/DefinitionLists.html#definition-lists Something markdown doesn't offer. But we don't need to switch to them here.
@ -26,0 +25,4 @@
],
// Both special specs are kept (lossless import); they share day + opens and
// differ only by validity window. Each language version of the attraction
// (de uid 1, en uid 2) carries its own inline children → 4 rows.

Should we also assert the records count column?

Should we also assert the records count column?
@ -74,4 +74,57 @@ return [
'special_opening_hours' => '',
],
],
// Inline opening hours for attraction 21, resolved via parentid/parenttable.

Should we also assert the records count column?

Should we also assert the records count column?
@ -162,4 +159,0 @@
public function importsTouristAttractionsWithFilteredOpeningHours(): void
{
// Reference date for past-date filtering: assertion keeps the 2050
// entry and drops the 2021 one, so any "now" between them works.

Can we now remove the setDateAspect() method completely?

Can we now remove the `setDateAspect()` method completely?
All checks were successful
CI / base-qa (pull_request) Successful in 17s
Required
Details
CI / advanced-qa (82, ^13.4) (pull_request) Successful in 2m28s
Required
Details
CI / advanced-qa (82, ^14) (pull_request) Successful in 2m35s
Required
Details
CI / advanced-qa (83, ^13.4) (pull_request) Successful in 2m22s
Required
Details
CI / advanced-qa (83, ^14) (pull_request) Successful in 2m26s
Required
Details
CI / advanced-qa (84, ^13.4) (pull_request) Successful in 2m17s
Required
Details
CI / advanced-qa (84, ^14) (pull_request) Successful in 2m29s
Required
Details
CI / advanced-qa (85, ^13.4) (pull_request) Successful in 2m17s
Required
Details
CI / advanced-qa (85, ^14) (pull_request) Successful in 2m25s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 10902_opening_hours:10902_opening_hours
git switch 10902_opening_hours
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
typo3/thuecat!152
No description provided.