typo3/watchlist
3
0
Fork 0
Code Issues Pull requests Activity Actions

Fix broken cookie handling on PHP side #20

Merged
DanielSiepmann merged 1 commit from fix-cookie-php-side into main 2024-02-21 09:16:34 +00:00
Conversation 1 Commits 1 Files changed 6 +88 -12
DanielSiepmann commented 2024-02-20 13:34:37 +00:00 (Migrated from github.com)
Copy link

Fix broken cookie path within middleware. For some reason we used the /typo3/ path while storing cookies server side. But we used / in JavaScript. That didn't play together and was fixed to always be / for now, but it should be configurable in general. The fix revealed that the detection of whether to store a cookie was broken, which was fixed within the corresponding service.

Furthermore the dates how long the cookie should be stored was different. We now always use 7 days.

Fix broken cookie path within middleware. For some reason we used the `/typo3/` path while storing cookies server side. But we used `/` in JavaScript. That didn't play together and was fixed to always be `/` for now, but it should be configurable in general. The fix revealed that the detection of whether to store a cookie was broken, which was fixed within the corresponding service. Furthermore the dates how long the cookie should be stored was different. We now always use 7 days.
justusmoroni (Migrated from github.com) approved these changes 2024-02-21 08:58:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
justusmoroni
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
typo3/watchlist!20
No description provided.