typo3/watchlist
3
0
Fork 0
Code Issues Pull requests Activity Actions

[FEATURE] Allow replacement of cookie implementation #22

Merged
d-g-codappix merged 1 commit from 21-use-sessionserviceinterface-in-middleware into main 2025-02-10 08:04:50 +00:00
Conversation 2 Commits 1 Files changed 4 +22 -4
d-g-codappix commented 2025-02-07 15:19:23 +00:00 (Migrated from github.com)
Copy link

The implementation is now extracted into an interface.
That way it is easier to replace the concrete implementation for cookie
handling
with a custom one.

Relates: #21

The implementation is now extracted into an interface. That way it is easier to replace the concrete implementation for cookie handling with a custom one. Relates: #21
d-s-codappix commented 2025-02-10 06:45:05 +00:00 (Migrated from github.com)
Copy link

Thanks for providing the PR.
Right now the CI fails, as the Interface doesn't define any of the methods used within the Middleware.
And that's correct, as the middleware was hard-wired to the cookie implementation, and only using methods provided by that implementation.

I currently do not see any need to use the general implementation. E.g. an implementation for FE or BE users wouldn't need a middleware in my opinion.

Maybe you can explain the actual use case to me? That way we can find a proper implementation.

Thanks for providing the PR. Right now the CI fails, as the Interface doesn't define any of the methods used within the Middleware. And that's correct, as the middleware was hard-wired to the cookie implementation, and only using methods provided by that implementation. I currently do not see any need to use the general implementation. E.g. an implementation for FE or BE users wouldn't need a middleware in my opinion. Maybe you can explain the actual use case to me? That way we can find a proper implementation.
d-s-codappix (Migrated from github.com) reviewed 2025-02-10 07:55:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
typo3/watchlist!22
No description provided.